Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for python 3.13 and drop support for python 3.10 #666

Merged
merged 11 commits into from
Jan 3, 2025

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Sep 13, 2024

TODO:

@ekneg54 ekneg54 added the enhancement New feature or request label Sep 13, 2024
@ekneg54 ekneg54 self-assigned this Sep 13, 2024
@ekneg54 ekneg54 force-pushed the dev-update-python-versions branch 2 times, most recently from 729c03e to 18cfd83 Compare October 9, 2024 16:34
@ekneg54 ekneg54 force-pushed the dev-update-python-versions branch from 9b8b521 to 1c819e2 Compare October 29, 2024 14:31
@ekneg54 ekneg54 force-pushed the dev-update-python-versions branch from 1c819e2 to 332a184 Compare December 30, 2024 20:14
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (a4eb13d) to head (1c4481f).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   94.32%   96.58%   +2.26%     
==========================================
  Files         146      145       -1     
  Lines        9724     9350     -374     
==========================================
- Hits         9172     9031     -141     
+ Misses        552      319     -233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

newly added in python3.13 https://docs.python.org/3/whatsnew/3.13.html#ipaddress
but is not json serializable
@ekneg54 ekneg54 requested review from djkhl and dtrai2 December 30, 2024 20:38
@ekneg54 ekneg54 marked this pull request as ready for review December 30, 2024 20:38
@ekneg54
Copy link
Collaborator Author

ekneg54 commented Dec 30, 2024

There is a good chance that python 3.13 is the faster option for your configuration. Measurements showed that it is the better python for a config with the http_input connector.

@ekneg54 ekneg54 force-pushed the dev-update-python-versions branch 2 times, most recently from a13669e to 6ca0e95 Compare January 2, 2025 13:16
@ekneg54 ekneg54 marked this pull request as draft January 2, 2025 13:17
@ekneg54 ekneg54 removed request for djkhl and dtrai2 January 2, 2025 13:17
@ekneg54 ekneg54 requested a review from djkhl January 2, 2025 14:33
@ekneg54 ekneg54 marked this pull request as ready for review January 2, 2025 14:33
@ekneg54 ekneg54 requested a review from ppcad January 2, 2025 14:33
@ekneg54
Copy link
Collaborator Author

ekneg54 commented Jan 2, 2025

had to fix the acceptance tests so that they will be skipped in CI on python 3.13 in cause of a strange bug that only occurs in CI on python 3.13. We can investigate that later.

@ekneg54 ekneg54 requested a review from dtrai2 January 3, 2025 09:53
@ekneg54 ekneg54 merged commit 5828127 into main Jan 3, 2025
13 checks passed
@ekneg54 ekneg54 deleted the dev-update-python-versions branch January 3, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants